[PATCH] rewrite release phases in chronological order
|Reported by:||gcooper||Owned by:|
The release phases that have been used in FreeNAS/TrueNAS have been:
ALPHA BETA RC PRERELEASE RELEASE
At times I skipped the earlier phases for TrueNAS to avoid commit churn, and FreeNAS really hasn't used PRERELEASE either. But nonetheless, following the above convention noted above is used by the FreeBSD project is the set of release phases that should be following logically/chronologically from start to finish for each release.
As discussed over email, there's a bug in the underlying assumption made in check_version, where if all release phases were used, there would be a bug in comparing versions going from RC -> PRERELEASE, where the former would be considered a "higher version" because alphabetically PRERELEASE is sorted before RC [when LANG=C].
The attached patch enhances the process, so the the release phase is mapped to the numeric phase in the entire release process to ensure that the version strings are compared properly.
The other concern about LANG=C I mentioned previously is moot given other checks and balances employed to comparing the project and because the versions are compared after the release phases have been rewritten in rewrite_release_phases.