Domain isn't properly sanitized in user/groups input

[gcooper]

I tried putting in a domain lowercase instead of uppercase, and yeah... it didn't work too well...

Traceback:
File "/usr/local/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  105.                         response = middleware_method(request, callback, callback_args, callback_kwargs)
File "/usr/local/www/freenasUI/freeadmin/middleware.py" in process_view
  58.         return login_required(view_func)(request,*view_args,**view_kwargs)
File "/usr/local/lib/python2.7/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
  23.                 return view_func(request, *args, **kwargs)
File "/usr/local/www/freenasUI/storage/views.py" in mp_permission
  463.         if form.is_valid():
File "/usr/local/lib/python2.7/site-packages/django/forms/forms.py" in is_valid
  121.         return self.is_bound and not bool(self.errors)
File "/usr/local/lib/python2.7/site-packages/django/forms/forms.py" in _get_errors
  112.             self.full_clean()
File "/usr/local/lib/python2.7/site-packages/django/forms/forms.py" in full_clean
  267.         self._clean_fields()
File "/usr/local/lib/python2.7/site-packages/django/forms/forms.py" in _clean_fields
  284.                     value = field.clean(value)
File "/usr/local/www/freenasUI/freeadmin/forms.py" in clean
  101.         if FreeNAS_User(user) == None:
File "/usr/local/www/freenasUI/common/freenasusers.py" in __new__
  275.         obj = FreeNAS_Directory_User(user, **kwargs)
File "/usr/local/www/freenasUI/common/freenasldap.py" in __new__
  1970.             obj = FreeNAS_ActiveDirectory_User(user, **kwargs)
File "/usr/local/www/freenasUI/common/freenasldap.py" in __init__
  1928.         super(FreeNAS_ActiveDirectory_User, self).__init__(**kwargs)
File "/usr/local/www/freenasUI/common/freenasldap.py" in __init__
  1274.         super(FreeNAS_ActiveDirectory, self).__init__(**kwargs)
File "/usr/local/www/freenasUI/common/freenasldap.py" in __init__
  864.                     args['host'] = d['dnsRoot'] 

Exception Type: NameError at /storage/mountpoint/permission/25/
Exception Value: global name 'args' is not defined

[jhixson]

This is by design. At some point, the example said to use all caps, the documentation just needs to be updated.

[gcooper]

For documentation purposes, this is what I did in the GUI on a customer box...

Procedure:

1. Storage -> Volumes -> /mnt/tank -> Change Permissions.
2. Change "Owner (group)" to "workgroup\domain admins" (not "WORKGROUP\domain admins").
3. Press Ok.

Expected Result:

• GUI should sanitize the input.
• The permissions should be changed appropriately.

Actual result:

• See traceback above.