Opened 18 months ago

Closed 18 months ago

#1100 closed defect (wontfix)

Small Typo in freenas-common@9135 (8.0.3)

Reported by: protosd Owned by:
Priority: trivial Milestone:
Component: Build System Version: 8.0.2-RELEASE
Keywords: Cc:

Description

8.03 Beta freenas-common@9135

Line #55 "Kleep"

54      # REVISION gets overloaded when doing tagged versions, SVNREVISION allows
55	# us to '''kleep''' the SVN revision number even when the version string is
56	# overloaded with a name.

Change History (1)

comment:1 Changed 18 months ago by gcooper

  • Resolution set to wontfix
  • Status changed from new to closed

The typo's been fixed on trunk (along with a handful of others), when this section of code was moved to build/nano_env . Given that 8.0.x is a sustaining branch, I'd like to live with the benign typos because the proposed change would be fixing a non-issue on a development branch that matters :). I'm always open to logic fixes when it affects the resulting image, or if it improves image builds in a quantifiable way.

Note: See TracTickets for help on using tickets.