Form validation broken for incorrect home user dirs (since before 8.0.3)

[gcooper]

1. Create or edit a user.
2. Enter in a path that either doesn't start with '/mnt' or '/nonexistent'.

Expected results:

1. GUI should provide feedback that the input is bogus.

Actual result (behavior differs, depending on the version):

• 8.0.2:

1. Prints out a traceback (says that 'bsdusr_home' isn't in self.cleaned_data).
2. Doesn't add/modify the user.

• trunk:

1. Prints out undefined in the dialog.
2. Doesn't add/modify the user.

This issue has existed since 8.0.2-p1 at least... I vaguely remember it working before then, but I believe that the clean logic is incorrect.

[gcooper]

I take that back. It _does_ traceback if you enable tracebacks in the GUI. So the 'An error occurred' message is broken now.

[yaberauneya]

In [9039/freenas]:

Fix tracebacks which occur if with invalidating home directories.

This occurs on 8.0.2+ if an SSH pubkey was provided and the path provided for the home directory was invalidated, in particular:

1. /nonexistent was provided for a home directory when creating a new user.
2. /nonexistent or /root was provided as the user's home directory when modifying an existing user.

This addresses ticket 1082.

[yaberauneya]

In [9040/freenas]:

Merge changes from trunk to 8.0.3

---

r9039 | yaberauneya | 2011-12-09 00:49:54 -0800 (Fri, 09 Dec 2011) | 9 lines

Fix tracebacks which occur if with invalidating home directories.

This occurs on 8.0.2+ if an SSH pubkey was provided and the path provided for the home directory was invalidated, in particular:

1. /nonexistent was provided for a home directory when creating a new user.
2. /nonexistent or /root was provided as the user's home directory when modifying an existing user.

This addresses ticket 1082.

[yaberauneya]

In [9040/freenas]:

Merge changes from trunk to 8.0.3

---

r9039 | yaberauneya | 2011-12-09 00:49:54 -0800 (Fri, 09 Dec 2011) | 9 lines

Fix tracebacks which occur if with invalidating home directories.

This occurs on 8.0.2+ if an SSH pubkey was provided and the path provided for the home directory was invalidated, in particular:

1. /nonexistent was provided for a home directory when creating a new user.
2. /nonexistent or /root was provided as the user's home directory when modifying an existing user.

This addresses ticket 1082.